Skip to content

Add Debian repo config path #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tariq1890 merged 1 commit into from
Jan 9, 2026
Merged

Add Debian repo config path #2023

tariq1890 merged 1 commit into from
Jan 9, 2026

Conversation

@sathieu
Copy link
Contributor

@sathieu sathieu commented Jan 7, 2026 •
edited
Loading

Description

Related to NVIDIA/gpu-driver-container#531

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 7, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

tariq1890
tariq1890 previously approved these changes Jan 8, 2026
View reviewed changes
@tariq1890
Copy link
Contributor

tariq1890 commented Jan 8, 2026

/ok to test a79ab2f

rahulait
rahulait reviewed Jan 8, 2026
View reviewed changes
internal/state/driver_volumes.go
var RepoConfigPathMap = map[string]string{
"centos": "/etc/yum.repos.d",
"debian": "/etc/apt/sources.list.d",
"ubuntu": "/etc/apt/sources.list.d",
Copy link
Contributor

@rahulait rahulait Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update CertConfigPathMap as well below?

Copy link
Contributor Author

@sathieu sathieu Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulait Good idea. Done.

@tariq1890 tariq1890 dismissed their stale review January 8, 2026 21:59

review comment needs to be addressed

rahulait
rahulait approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulait
Copy link
Contributor

rahulait commented Jan 9, 2026

/ok to test b324067

@rahulait rahulait requested a review from tariq1890 January 9, 2026 16:13
@tariq1890
Copy link
Contributor

tariq1890 commented Jan 9, 2026

@sathieu Let's update here too

@rahulait rahulait self-requested a review January 9, 2026 17:59
@sathieu
Copy link
Contributor Author

sathieu commented Jan 9, 2026

@sathieu Let's update here too

Good catch, now fixed 🙏.

@tariq1890
Copy link
Contributor

tariq1890 commented Jan 9, 2026

/ok to test 3bc523e

@tariq1890 tariq1890 enabled auto-merge January 9, 2026 20:21
@tariq1890 tariq1890 merged commit 616cadc into NVIDIA:main Jan 9, 2026
16 checks passed
@cdesiniotis cdesiniotis added this to the v26.3 milestone Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@rahulait rahulait rahulait approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@cdesiniotis cdesiniotis Awaiting requested review from cdesiniotis cdesiniotis is a code owner

@elezar elezar Awaiting requested review from elezar elezar is a code owner

@shivamerla shivamerla Awaiting requested review from shivamerla shivamerla is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v26.3

Development

Successfully merging this pull request may close these issues.

4 participants

@sathieu @tariq1890 @rahulait @cdesiniotis